Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix argument documentation of transpile functions #11728

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix argument documentation of transpile functions #11728

merged 1 commit into from
Feb 7, 2024

Conversation

kevinsung
Copy link
Contributor

Summary

Details and comments

@kevinsung kevinsung requested a review from mtreinish February 6, 2024 19:49
@kevinsung kevinsung requested a review from a team as a code owner February 6, 2024 19:49
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7805267321

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 89.2%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.19%
Totals Coverage Status
Change from base Build 7793984860: 0.001%
Covered Lines: 58816
Relevant Lines: 65937
💛 - Coveralls

ElePT
ElePT approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think that we can backport this to both 0.45 and 0.46.

@ElePT ElePT added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 7, 2024
@ElePT ElePT added this to the 1.0.0 milestone Feb 7, 2024
@ElePT ElePT added Changelog: None Do not include in changelog documentation Something is not clear or an error documentation labels Feb 7, 2024
@ElePT ElePT added this pull request to the merge queue Feb 7, 2024
Merged via the queue into Qiskit:main with commit 39952bc Feb 7, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
@kevinsung @mergify
fix argument documentation of transpile functions (#11728)
abfed23 
(cherry picked from commit 39952bc)
@mergify mergify bot mentioned this pull request Feb 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2024
@mergify @kevinsung
fix argument documentation of transpile functions (#11728) (#11732)
71f989d 
(cherry picked from commit 39952bc)

Co-authored-by: Kevin J. Sung <[email protected]>
@kevinsung kevinsung deleted the docs-fix branch February 7, 2024 19:54
@ElePT
Copy link
Contributor

ElePT commented Feb 8, 2024

https://github.com/Mergifyio backport stable/0.46

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2024 •
edited
Loading

backport stable/0.46

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 8, 2024
@kevinsung @mergify
fix argument documentation of transpile functions (#11728)
b95b9a8 
(cherry picked from commit 39952bc)
@mergify mergify bot mentioned this pull request Feb 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2024
@mergify @kevinsung
fix argument documentation of transpile functions (#11728) (#11754)
bc47c11 
(cherry picked from commit 39952bc)

Co-authored-by: Kevin J. Sung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@mtreinish mtreinish Awaiting requested review from mtreinish

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsung @qiskit-bot @coveralls @ElePT