Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove toqm from reserved names list #11792

Merged
merged 1 commit into from
Feb 13, 2024
Merged

remove toqm from reserved names list #11792

merged 1 commit into from
Feb 13, 2024

Conversation

kevinsung
Copy link
Contributor

@kevinsung kevinsung commented Feb 13, 2024 •
edited
Loading

Summary

toqm is not a reserved name for a transpiler stage plugin.

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner February 13, 2024 19:46
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@kevinsung kevinsung mentioned this pull request Feb 13, 2024
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7891931580

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 89.217%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 91.69%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 7890662128: 0.009%
Covered Lines: 58833
Relevant Lines: 65944
💛 - Coveralls

jakelishman
jakelishman approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true, thanks

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Feb 13, 2024
@jakelishman jakelishman added this pull request to the merge queue Feb 13, 2024
Merged via the queue into Qiskit:main with commit e871478 Feb 13, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
@kevinsung @mergify
remove toqm from reserved names list (#11792)
78de65f 
(cherry picked from commit e871478)
@mergify mergify bot mentioned this pull request Feb 13, 2024
Merged
@kevinsung kevinsung deleted the doc-fix branch February 13, 2024 21:52
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2024
@mergify @kevinsung
remove toqm from reserved names list (#11792) (#11793)
15aea97 
(cherry picked from commit e871478)

Co-authored-by: Kevin J. Sung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsung @qiskit-bot @coveralls @jakelishman