Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert memory-owning expr.Var nodes (#11667)" #11820

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jakelishman
Copy link
Member

This reverts commit 052d889.

This gets us re-started on #10922.

@jakelishman jakelishman added Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Feb 16, 2024
@jakelishman jakelishman added this to the 1.1.0 milestone Feb 16, 2024
@jakelishman jakelishman requested a review from a team as a code owner February 16, 2024 14:14
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7931811688

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -10 of 259 (96.14%) changed or added relevant lines in 8 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/classical/expr/expr.py 16 17 94.12%
qiskit/circuit/store.py 33 35 94.29%
qiskit/circuit/controlflow/builder.py 45 48 93.75%
qiskit/circuit/quantumcircuit.py 132 136 97.06%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.69%
crates/qasm2/src/parse.rs 12 95.77%
Totals Coverage Status
Change from base Build 7923082089: 0.02%
Covered Lines: 59125
Relevant Lines: 66222

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight revert, lets restore this on main now so we can finish the feature for 1.1.0.

@mtreinish mtreinish added this pull request to the merge queue Feb 26, 2024
Merged via the queue into Qiskit:main with commit 244940a Feb 26, 2024
12 checks passed
@jakelishman jakelishman deleted the readd-classical-store branch February 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants