Fix unhandled exception in _has_connection() function #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit address an issue where the socket calls we use to check if there is external connectivity raises an exception that is no from the socket lib. There are many reasons why this could occur including a different class of network or firewall issue. To address all the potential edge cases this changes the _has_connection() function to treat any exception, not just those from the socket lib, as being unable to connect and will return False. Fixes Qiskit#1225
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
jaygambetta
approved these changes
Nov 7, 2018
|
My understanding from the documentation is that is enough to catch |
|
I think you're correct those are the other likely errors raised by the socket lib for our calls. But there are still things like ValueError or TypeError being raised (although those are very uncommon). My thoughts here were that if any exception is raised during the connectivity check that means we can't establish connectivity. We don't want to raise an exception if testing the connectivity fails at all since that tells us we can't connect for whatever reason |
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This commit address an issue where the socket calls we use to check if there is external connectivity raises an exception that is no from the socket lib. There are many reasons why this could occur including a different class of network or firewall issue. To address all the potential edge cases this changes the _has_connection() function to treat any exception, not just those from the socket lib, as being unable to connect and will return False. Fixes Qiskit#1225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit address an issue where the socket calls we use to check if
there is external connectivity raises an exception that is no from the
socket lib. There are many reasons why this could occur including a
different class of network or firewall issue. To address all the
potential edge cases this changes the _has_connection() function to
treat any exception, not just those from the socket lib, as being unable
to connect and will return False.
Details and comments
Fixes #1225