Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document entanglement="pairwise" for EfficientSU2 #12314

Merged
merged 1 commit into from
May 1, 2024
Merged

document entanglement="pairwise" for EfficientSU2 #12314

merged 1 commit into from
May 1, 2024

Conversation

kevinsung
Copy link
Contributor

Summary

Fixes #12313

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner April 30, 2024 19:36
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@kevinsung kevinsung enabled auto-merge April 30, 2024 19:36
@kevinsung kevinsung added this to the 1.1.0 milestone Apr 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8900606803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 89.468%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.03%
crates/qasm2/src/lex.rs 1 92.62%
Totals Coverage Status
Change from base Build 8900042661: 0.009%
Covered Lines: 61112
Relevant Lines: 68306
💛 - Coveralls

ShellyGarion
ShellyGarion approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@kevinsung kevinsung added this pull request to the merge queue May 1, 2024
@ShellyGarion ShellyGarion added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels May 1, 2024
Merged via the queue into Qiskit:main with commit c6ba3a8 May 1, 2024
13 checks passed
@kevinsung kevinsung deleted the doc-pairwise branch May 1, 2024 11:11
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
@kevinsung @ElePT
document entanglement="pairwise" for EfficientSU2 (Qiskit#12314)
c02ebdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyGarion ShellyGarion ShellyGarion approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

entanglement="pairwise" for EfficientSU2 is not documented
4 participants
@kevinsung @qiskit-bot @coveralls @ShellyGarion