Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export SamplerPubResult in qiskit.primitives module #12406

Merged
merged 1 commit into from
May 15, 2024
Merged

export SamplerPubResult in qiskit.primitives module #12406

merged 1 commit into from
May 15, 2024

Conversation

kevinsung
Copy link
Contributor

@kevinsung kevinsung commented May 14, 2024 •
edited
Loading

Summary

Not sure if this was intentionally left out. If so, feel free to close.

Details and comments

@kevinsung kevinsung requested review from a team as code owners May 14, 2024 23:03
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

@kevinsung kevinsung added this to the 1.1.0 milestone May 14, 2024
@kevinsung kevinsung requested a review from ihincks May 14, 2024 23:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9087329076

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.623%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 7 91.86%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9086384288: -0.02%
Covered Lines: 62302
Relevant Lines: 69516
💛 - Coveralls

t-imamichi
t-imamichi approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Good catch!

@t-imamichi t-imamichi added mod: primitives Related to the Primitives module Changelog: None Do not include in changelog labels May 15, 2024
@kevinsung kevinsung added this pull request to the merge queue May 15, 2024
Merged via the queue into Qiskit:main with commit c6c45a1 May 15, 2024
15 checks passed
@kevinsung kevinsung deleted the export-samplerpubresult branch May 15, 2024 04:47
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
@kevinsung @ElePT
export SamplerPubResult in qiskit.primitives module (Qiskit#12406)
16c8a30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-imamichi t-imamichi t-imamichi approved these changes

@ihincks ihincks Awaiting requested review from ihincks

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog mod: primitives Related to the Primitives module
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsung @qiskit-bot @coveralls @t-imamichi