-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MCX recursive synthesis method to reduce number of CX gates #12772
Merged
+77
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the recursive method for the Lemma 9 of arXiv:1501.06911, first shown in Lemma 7.3 of https://link.aps.org/doi/10.1103/PhysRevA.52.3457 Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]>
This reverts commit 507d5b3. Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]>
This reverts commit 4671b7e.
Fixing co-authors Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> Co-Authored-By: Adenilton Silva <[email protected]>
Now with fixed co-authors Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> Co-Authored-By: Adenilton Silva <[email protected]>
One or more of the following people are relevant to this code:
|
Closed
Comparison of the old vs. new code:
Current code:
New code:
|
For |
Loading status checks…
Pull Request Test Coverage Report for Build 9973712807Details
💛 - Coveralls |
Cryoris
reviewed
Jul 17, 2024
releasenotes/notes/mcx_recursive_clean_ancilla-2b0f6956e0f4cbbd.yaml
Outdated
Show resolved
Hide resolved
Cryoris
reviewed
Jul 17, 2024
releasenotes/notes/mcx_recursive_clean_ancilla-2b0f6956e0f4cbbd.yaml
Outdated
Show resolved
Hide resolved
Some further experiments with more qubits:
|
Cryoris
approved these changes
Jul 17, 2024
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…iskit#12772) * Optimization for the MCX Recursive Gate Change the recursive method for the Lemma 9 of arXiv:1501.06911, first shown in Lemma 7.3 of https://link.aps.org/doi/10.1103/PhysRevA.52.3457 Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> * Revert "Optimization for the MCX Recursive Gate" This reverts commit 507d5b3. Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> * Revert "Revert "Optimization for the MCX Recursive Gate"" This reverts commit 4671b7e. * Optimization for MCX Recursive Fixing co-authors Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> Co-Authored-By: Adenilton Silva <[email protected]> * Optimization of MCX Recursive Now with fixed co-authors Co-Authored-By: Rafaella Vale <[email protected]> Co-Authored-By: Jefferson Deyvis <[email protected]> Co-Authored-By: Adenilton Silva <[email protected]> * refactored MCXRecursive and unused method deleted * fixed qasm string for mcx test with variants * remove draw * fix qasm file in test_circuit_qasm_with_mcx_gate_variants * update the MCXRecursive class docstring * add a test of the upper bound limit of the number of CX gates * fix failing qasm test * fix qasm file in test_export in qasm2 tests * fix format lint errors in qasm strings * add release notes * update references format * update release notes after review --------- Co-authored-by: Thiago Melo <[email protected]> Co-authored-by: Rafaella Vale <[email protected]> Co-authored-by: Jefferson Deyvis <[email protected]> Co-authored-by: Adenilton Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: New Feature
Include in the "Added" section of the changelog
mod: circuit
Related to the core of the `QuantumCircuit` class or the circuit library
synthesis
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #9743.
This PR replaces #8710 in order to get it merged on time for qiskit 1.2 release.
Details and comments