-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise minimum python version to 3.9 #12910
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b0d1d64
Raise minimum python version to 3.9
mtreinish 3eef5ab
Merge remote-tracking branch 'origin/main' into py39-now-and-forever
mtreinish 31418ae
Pin dependency versions when installing historical versions
mtreinish a362366
Update reference images
mtreinish 0a992f7
Drop 3.8 support in asv too
mtreinish 9d19eae
Merge branch 'main' into py39-now-and-forever
mtreinish 71f00b1
Remove deprecation warning for 3.8
mtreinish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,35 +41,6 @@ jobs: | |
with: | ||
path: ./wheelhouse/*.whl | ||
name: wheels-${{ matrix.os }} | ||
build_wheels_macos_arm_py38: | ||
name: Build wheels on macOS arm | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [macos-12] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
name: Install Python | ||
with: | ||
python-version: '3.10' | ||
- uses: dtolnay/rust-toolchain@stable | ||
with: | ||
components: llvm-tools-preview | ||
- name: Build wheels | ||
uses: pypa/[email protected] | ||
env: | ||
CIBW_BEFORE_ALL: rustup target add aarch64-apple-darwin | ||
CIBW_BUILD: cp38-macosx_universal2 cp38-macosx_arm64 | ||
CIBW_ARCHS_MACOS: arm64 universal2 | ||
CIBW_ENVIRONMENT: >- | ||
CARGO_BUILD_TARGET="aarch64-apple-darwin" | ||
PYO3_CROSS_LIB_DIR="/Library/Frameworks/Python.framework/Versions/$(python -c 'import sys; print(str(sys.version_info[0])+"."+str(sys.version_info[1]))')/lib/python$(python -c 'import sys; print(str(sys.version_info[0])+"."+str(sys.version_info[1]))')" | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
path: ./wheelhouse/*.whl | ||
name: wheels-${{ matrix.os }}-arm | ||
build_wheels_32bit: | ||
name: Build wheels 32bit | ||
runs-on: ${{ matrix.os }} | ||
|
@@ -100,7 +71,7 @@ jobs: | |
environment: release | ||
permissions: | ||
id-token: write | ||
needs: ["build_wheels", "build_wheels_32bit", "build_wheels_macos_arm_py38"] | ||
needs: ["build_wheels", "build_wheels_32bit"] | ||
steps: | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta" | |
[project] | ||
name = "qiskit" | ||
description = "An open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives." | ||
requires-python = ">=3.8" | ||
requires-python = ">=3.9" | ||
license = {text = "Apache 2.0"} | ||
authors = [ | ||
{ name = "Qiskit Development Team", email = "[email protected]" }, | ||
|
@@ -27,7 +27,6 @@ classifiers = [ | |
"Operating System :: Microsoft :: Windows", | ||
"Operating System :: POSIX :: Linux", | ||
"Programming Language :: Python :: 3 :: Only", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
|
@@ -140,12 +139,12 @@ include = ["qiskit", "qiskit.*"] | |
|
||
[tool.black] | ||
line-length = 100 | ||
target-version = ['py38', 'py39', 'py310', 'py311'] | ||
target-version = ['py39', 'py310', 'py311'] | ||
|
||
[tool.cibuildwheel] | ||
manylinux-x86_64-image = "manylinux2014" | ||
manylinux-i686-image = "manylinux2014" | ||
skip = "pp* cp36-* cp37-* *musllinux* *win32 *i686 cp38-macosx_arm64" | ||
skip = "pp* cp36-* cp37-* cp38-* *musllinux* *win32 *i686 cp38-macosx_arm64" | ||
test-skip = "*win32 *linux_i686" | ||
test-command = "python {project}/examples/python/stochastic_swap.py" | ||
# We need to use pre-built versions of Numpy and Scipy in the tests; they have a | ||
|
@@ -197,7 +196,7 @@ extension-pkg-allow-list = [ | |
"tweedledum", | ||
] | ||
load-plugins = ["pylint.extensions.docparams", "pylint.extensions.docstyle"] | ||
py-version = "3.8" # update it when bumping minimum supported python version | ||
py-version = "3.9" # update it when bumping minimum supported python version | ||
|
||
[tool.pylint.basic] | ||
good-names = ["a", "b", "i", "j", "k", "d", "n", "m", "ex", "v", "w", "x", "y", "z", "Run", "_", "logger", "q", "c", "r", "qr", "cr", "qc", "nd", "pi", "op", "b", "ar", "br", "p", "cp", "ax", "dt", "__unittest", "iSwapGate", "mu"] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
upgrade: | ||
- | | ||
The minimum supported version of Python is now 3.9, this has been raised | ||
from the previous minimum support version of 3.8. This change was necessary | ||
because the upstream cPython project no longer supports Python 3.8. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
numpy===1.24.4 | ||
scipy===1.10.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.97 KB
(100%)
test/visual/mpl/graph/references/bloch_multivector_figsize_improvements.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue appears to be closed now actions/setup-python#808, are we planning on making any updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix this in a follow-up. There isn't a super big motivation to change it as using 3.10 works fine, but if we could get 3.9 running instead of 3.10 that would at least make everything consistent. But I think we can also look at doing it as part of #12807 too