Fix Rust-space TwoQubitBasisDecomposer for non-standard KAK gate
#13014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en KAK gate is a Rust-space StandardGate
ElePT
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
ElePT
added
the
Changelog: Bugfix
ElePT
changed the title
TwoQubitBasisDecomposer for not Rust-space standard KAK gateTwoQubitBasisDecomposer for non-standard KAK gate
mtreinish
added
the
stable backport potential
Pull Request Test Coverage Report for Build 10527903608Details
💛 - Coveralls |
mtreinish
reviewed
Aug 22, 2024
| Reproduce from: https://github.com/Qiskit/qiskit/issues/12998 | ||
| """ | ||
| # note that `CXGate(ctrl_state=0)` is not handled as a "standard" gate. | ||
| TwoQubitBasisDecomposer(CXGate(ctrl_state=0))(CXGate()) |
There was a problem hiding this comment.
The bug was only present when building the circuit. Can you update this to pass it a unitary matrix to synthesize and maybe assert the output circuit's operator is equivalent to the input and your pygate is correctly used.
There was a problem hiding this comment.
Oh I misread this it is creating a circuit from cx's matrix. It'd still be good to add the assertions though.
There was a problem hiding this comment.
That's totally on me, I just copied the reproducing example without trying to make it readable. It should look better now :)
mtreinish
reviewed
Aug 22, 2024
Co-authored-by: Matthew Treinish <[email protected]>
mtreinish
approved these changes
Aug 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
…13014) * Get rid of encoded assumption in TwoQubitBasisDecomposer that the given KAK gate is a Rust-space StandardGate * Improve unit test * Update test/python/synthesis/test_synthesis.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit a4bf87b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…13014) (#13026) * Get rid of encoded assumption in TwoQubitBasisDecomposer that the given KAK gate is a Rust-space StandardGate * Improve unit test * Update test/python/synthesis/test_synthesis.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit a4bf87b) Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposal to fix #12998. I can probably extend the unit tests further.
Details and comments