Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pulse-related deprecation #13392

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

eliarbel
Copy link
Contributor

@eliarbel eliarbel commented Nov 3, 2024

This commit deprecates inst_map in PassManagerConfig.__init__. It should have been part of the pulse deprecation PR #13164 but I somehow missed to cover it. We're already in our feature freeze period for version 1.3 but since this is not a new feature but rather an addendum to the pulse deprecation PR we should squeeze this in as well.

This commit deprecates `inst_map` in `PassManagerConfig.__init__`. It should have
been part of the pulse deprecation PR Qiskit#13164 but I somehow missed to covere it. We're
already in our feature freeze period for version 1.3 but since this is not a new feature
but rather an addendum to the pulse deprecation PR  we should squeeze this in as well.
@eliarbel eliarbel added this to the 1.3.0 milestone Nov 3, 2024
@eliarbel eliarbel requested a review from a team as a code owner November 3, 2024 09:04
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11649694905

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.726%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/qasm2/src/lex.rs 4 91.73%
crates/qasm2/src/parse.rs 6 96.69%
Totals Coverage Status
Change from base Build 11636461507: 0.01%
Covered Lines: 76426
Relevant Lines: 86137

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it makes a lot of sense to include this PR in the release, else the deprecation would be incomplete. I'm glad you caught this on time! It totally flew over my head.

@ElePT ElePT added this pull request to the merge queue Nov 4, 2024
Merged via the queue into Qiskit:main with commit c676788 Nov 4, 2024
17 checks passed
@eliarbel eliarbel added the Changelog: Deprecation Include in "Deprecated" section of changelog label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants