Fix 4-pi periodicity of controlled rotations in the CommutationChecker
#13670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
Cryoris
changed the title
CommutationCheckerCommutationChecker
Pull Request Test Coverage Report for Build 12811238577Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
reviewed
Jan 16, 2025
alexanderivrii
approved these changes
Jan 16, 2025
alexanderivrii
added
the
stable backport potential
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
…er` (#13670) (#13676) * start * fix 4pi periodicity of controlled pauli rots * review comments by Elena & Sasha (cherry picked from commit dffc2df) # Conflicts: # crates/accelerate/src/commutation_checker.rs Co-authored-by: Julien Gacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The commutation checker currently wrongly assumes that the controlled Pauli rotations CRX/Y/Z are equivalent to the identity for multiples of$2\pi$ . However, this is only true for $4\pi$ . Note that CP is indeed $2\pi$ periodic.
Details and comments
The tests were modified to compare the output of the commutation checker to a numeric result instead of a hardcoded one, such that this error shouldn't arise in the future again.