Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a round feature #1381

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Adding a round feature #1381

merged 2 commits into from
Nov 30, 2018

Conversation

jaygambetta
Copy link
Member

@jaygambetta jaygambetta commented Nov 30, 2018

Adding a rounding feature to the get_commands in results. I am tired of seeing numbers at 17 decimals when it is zero.

Adding a rounding feature to the get_commands
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we could add a changelog entry for the new field (and maybe some quick unit tests changing the value of the new kwarg), but that's pretty simple and we can do that in a follow up.

@jaygambetta
Copy link
Member Author

ok i merge and we can do that later. I decided not to test as it is tested by default but i agree we should allow a case where the decimals are changed.

@jaygambetta jaygambetta merged commit 6a9c7a8 into Qiskit:master Nov 30, 2018
@jaygambetta jaygambetta deleted the roundoff branch December 1, 2018 13:36
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
Adding a rounding feature to the get_commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants