Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete erroneous note in XXMinusYY documentation #13837

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

kevinsung
Copy link
Contributor

Summary

Actually, it doesn't matter which qubit the phase is applied to because the gate only affects the symmetric subspace containing the 00 and 11 states.

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner February 13, 2025 14:59
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

There's an effort (on the back burner at the moment) to look over and improve all the circuit-library documentation, and personally I'd hope we can make these notes a lot better - I very much understand the bit-labelling conventions, and I find these notes super confusing, so I think we can do a better job.

That's unrelated to your PR of course, just me musing.

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Feb 13, 2025
@jakelishman jakelishman added this to the 1.3.3 milestone Feb 13, 2025
@jakelishman jakelishman added this pull request to the merge queue Feb 13, 2025
Merged via the queue into Qiskit:main with commit 8d7404b Feb 13, 2025
18 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
@kevinsung kevinsung deleted the xx-minus-yy-doc branch February 13, 2025 18:28
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 8d7404b)

Co-authored-by: Kevin J. Sung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants