Remove couplingdict argument from CouplingMap #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-reuter-2
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
mtreinish,
nonhermitian and
taalexander
as code owners
max-reuter-2
force-pushed
the
remove-couplingdict-arg-from-CouplingMap
branch
from
ad1f925 to
739dc45
Compare
… one input now (couplinglist)
jaygambetta
reviewed
Jan 15, 2019
test/python/test_mapper_coupling.py
Outdated
| @@ -23,13 +23,13 @@ def test_empty_coupling_class(self): | |||
|
|
|||
| def test_coupling_str(self): | |||
| coupling_list = [(0, 1), (0, 2), (1, 2)] | |||
There was a problem hiding this comment.
can we make this a list of lists.
jaygambetta
approved these changes
Jan 15, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Remove couplingdict parameter from CouplingMap * Remove import warnings module * Update changelog * Remove specification of arguments to CouplingMap init - there is only one input now (couplinglist) * Change elements in couplinglist from tuple to list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
couplingdictargument from CouplingMap and associated tests.Details and comments