Fix for Matplotlib barriers not plotting correctly #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddy-tod
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
mtreinish,
nonhermitian and
taalexander
as code owners
maddy-tod
changed the title
ajavadia
reviewed
Jan 25, 2019
|
Thanks @maddy-tod! This does fix the issue. After you fix the linter error, I'll merge. |
Co-Authored-By: maddy-tod <[email protected]>
…t-terra into matplot-barriers
1ucian0
approved these changes
Jan 29, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Barriers plot over all affected qubits * Tidying up * CHANGELOG update * CHANGELOG update * Update CHANGELOG.rst Co-Authored-By: maddy-tod <[email protected]> * fix linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1703
Barriers weren't plotting across all affected qubits. This was because only the first affected qubit was being added to the barrier. Fixed by adding all qubits given by the operation to the barrier.