Addressed issue with instruction.py which prohibited inheritance of Q… #1893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressed an issue whereby inheriting from
QuantumRegister
orClassicalRegister
would cause aQiskitError
ininstruction.py
. This PR addresses issue #1892 .Details and comments
Checking type-equality is brittle and should be avoided unless it is desired that only the given type be accepted. Since these classes are made available to the public, it is expected that they may eventually be inherited from.