Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed issue with instruction.py which prohibited inheritance of Q… #1893

Closed
wants to merge 3 commits into from
Closed

Addressed issue with instruction.py which prohibited inheritance of Q… #1893

wants to merge 3 commits into from

Conversation

Woody1193
Copy link
Contributor

@Woody1193 Woody1193 commented Mar 5, 2019

Summary

Addressed an issue whereby inheriting from QuantumRegister or ClassicalRegister would cause a QiskitError in instruction.py. This PR addresses issue #1892 .

Details and comments

Checking type-equality is brittle and should be avoided unless it is desired that only the given type be accepted. Since these classes are made available to the public, it is expected that they may eventually be inherited from.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Woody1193 Woody1193 closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants