Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support None for simulator backend coupling_map #1974

Merged
merged 10 commits into from
Mar 19, 2019
Merged

Support None for simulator backend coupling_map #1974

merged 10 commits into from
Mar 19, 2019

Conversation

nonhermitian
Copy link
Contributor

Summary

transpile now works correctly for simulators with coupling_map as required by the qiskit spec. BasicAer simulators now have coupling_map attributes in their configuration files

Details and comments

This PR is required for Qiskit/qiskit-aer#93 to pass as well.

@nonhermitian nonhermitian changed the title Transpile works for simulators with coupling maps and BasicAer has coupling map Support None for simulator backend coupling_map Mar 18, 2019
@ajavadia ajavadia added the type: specs Issues and PRs that involve modifications to the open specs label Mar 19, 2019
@nonhermitian nonhermitian merged commit 1ac2acf into Qiskit:master Mar 19, 2019
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* check cmap length for verifying all-to-all

* update

* allow for simulator coupling map

* allow for old behaviour to pass

* remind myself

* cmaps to None

* add allow none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement It's working, but needs polishing type: specs Issues and PRs that involve modifications to the open specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants