Update backend snapshots with new conf or defs #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue.
mtreinish
added
the
stable backport potential
|
This is at least partially fixing the CI failure on tutorials which is blocking the qiskit 0.20.0 metapackage release. The dt units in the json were wrong which was breaking the pulse simulation in https://github.com/Qiskit/qiskit-tutorials/blob/master/tutorials/pulse/8_pulse_simulator_backend_model.ipynb see: https://travis-ci.com/github/Qiskit/qiskit/jobs/370264840#L777 With this applied that error is fixed, although the simulation results are different (the oscillations are twice as fast) from in older versions. This looks to be caused by other differences in the payload snapshot for the hamiltonian. But this is just what the backends are returning now so there isn't a way to fix that in this PR. |
DanPuzzuoli
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Just double checked the Hamiltonian in the armonk config and it looks good to me (assuming the units are in GHz and ns).
We discussed this separately but just to record it here: the rabi oscillation change observed in the tutorial is due to the inclusion of a 3rd energy level in the Hamiltonian, but the anharmonicity is set to 0 (I assume following the convention that unreported parameters are set to 0). Testing things out locally, things return to normal when either (1) the system is truncated to 2 levels or (2) a "reasonable" value for the anharmonicity is inserted (hence validating to some extent the 2 level approximation).
taalexander
approved these changes
Aug 10, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2020
In #4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue. (cherry picked from commit 0f7673e)
mtreinish
added
the
Changelog: Bugfix
mergify bot
added a commit
that referenced
this pull request
Aug 10, 2020
In #4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue. (cherry picked from commit 0f7673e) Co-authored-by: Matthew Treinish <[email protected]>
lcapelluto
pushed a commit
to lcapelluto/qiskit-terra
that referenced
this pull request
Aug 12, 2020
In Qiskit#4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue.
mergify bot
added a commit
that referenced
this pull request
Aug 21, 2020
* Update the qobj schema to support pulse gate calibrations. * Fixup qobj classes: add docstrings, call out to super * Move pulse library to top level. Fill in more details in qasm_qobj.py * Fix mistake in schema: the pulse_library definition already contains the 'array' requirement * Move pulse library to top level in qasm_qobj.py as well * Add GateCalibration to qobj/__init__.py * Fixup some implementation errors: gates contains a list of dict items, which needed to be fixed in both the schema and the py files * Put gate calibrations into calibrations.gates to leave room for adding other metadata in the future. Make a qobj.common file to allow qobj.qasm to use features of qobj.pulse * Add an example json * Schema version should be referenced not hardcoded a second time * Pretty print example file * Check if calibrations is present when doing to from dict * Fixup qobj test * Update the qobj schema to support pulse gate calibrations. * Fixup qobj classes: add docstrings, call out to super * Move pulse library to top level. Fill in more details in qasm_qobj.py * Fix mistake in schema: the pulse_library definition already contains the 'array' requirement * Move pulse library to top level in qasm_qobj.py as well * Add GateCalibration to qobj/__init__.py * Fixup some implementation errors: gates contains a list of dict items, which needed to be fixed in both the schema and the py files * Put gate calibrations into calibrations.gates to leave room for adding other metadata in the future. Make a qobj.common file to allow qobj.qasm to use features of qobj.pulse * Add an example json * Schema version should be referenced not hardcoded a second time * Pretty print example file * Update backend snapshots with new conf or defs (#4897) In #4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue. * One reference to get_sample_pulse is raising deprecation warnings from the assembler (#4903) * Check if calibrations is present when doing to from dict * Fixup qobj test * Add qobj.config.calibrations for common cals * style * Move recent qasm qobj changes to the new qobj.common file * Update schema with qobj level and experiment level calibrations * Add schema test * Apply suggestions from code review Co-authored-by: SooluThomas <[email protected]> * Fix encoding for validation of new pulse library field in qasm qobj. Add qobj test Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: SooluThomas <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #4728 how we handle the difference between the object units and the
serialization format. However the snapshot update didn't actually save
the correct values in the json and this is causing issues for tutorials
that rely on this. This commit updates the backend snapshots for
backends by rerunning the update script to correct this issue.
Details and comments