-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #657 - Refactor Jobs interface #686
Merged
Merged
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
209cfd4
Issue 657 - Refactor Jobs interface
atilag 1ad63ea
Restoring status() property from ibmqbackend.
atilag 85e3cd4
* Better exception handling when there's an error in the thread
atilag f8fecb4
Addressing review comments
atilag cd14cec
Let's be friends linter...
atilag be58872
Fixed a bug where status() were called before self._future_exception
atilag a72ae09
* Fixed issue in LocalJob where calling some methods before .submit()
atilag 5aa59c4
Linter hungry is infinite
atilag cd1bd24
* Updating in code documentation
atilag abf750f
Merge branch 'master' into jobs_simplification
atilag daa9616
Merge branch 'master' into jobs_simplification
atilag 0b08f38
Added CHANGELOG entry for Jobs refactoring
atilag 7620fa5
Linter gods are happy now
atilag f9db8b5
Adressing review comments:
atilag f4b1f10
Adressing some of the comments from the reviewers:
atilag c9c58ae
Adressing review commments:
atilag 30cbfcf
* Removed all properties and some of them turned into methods.
atilag bb67805
* Fixed issues with error_msg not being properly managed
atilag 4f0721e
* Refactoring for improving readability
atilag 4851ae2
Merge branch 'master' into jobs_simplification
atilag 8469e77
* Fixing tests
atilag ad5a0d8
* Fixed some bugs caught by the linter
atilag 3fcf30a
* Lintering
atilag 8b0ab1d
Merge branch 'master' into jobs_simplification
delapuente d47b20d
Fixing test workflows
delapuente 622cd59
Fixing strings and comments.
delapuente File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace
its usage
withtheir usage
or refer to the``Job`` API
instead ofJobs
to preserve the singular possessive.