-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reverse_bits with registerless bits in all 3 circuit drawers #7319
Fix reverse_bits with registerless bits in all 3 circuit drawers #7319
Conversation
…/qiskit-terra into fix_single_clbit_display_7248
Pull Request Test Coverage Report for Build 1830645646
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this - the new form looks right. The way that registers interact in the "order" with respect to loose bits is slightly unusual, but that's because of the super weird position ClassicalRegister
is in right now in our data model - not the fault of this PR at all.
…51/qiskit-terra into fix_reverse_bits_registerless_2
…51/qiskit-terra into fix_reverse_bits_registerless_2
@jakelishman I have now deprecated |
…51/qiskit-terra into fix_reverse_bits_registerless_2
warn( | ||
"The 'circuit' kwarg to the QCircuitImage class must be a valid " | ||
"QuantumCircuit and not None. A new circuit is being created using " | ||
"the qubits and clbits for rendering the drawing.", | ||
DeprecationWarning, | ||
2, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a deprecation warning? What is being replaced with in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Edwin!
Summary
Fixes #7303
Details and comments
This PR fixes an issue with the 3 circuit drawers where the registerless bits indexing was not reversed when the
reverse_bits
option was used. It now correctly displays as,