Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass phase in PauliList.from_symplectic example #7436

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Pass phase in PauliList.from_symplectic example #7436

merged 1 commit into from
Dec 23, 2021

Conversation

garrison
Copy link
Member

Summary

I believe this is what was intended when the example was originally added (#5993), as this now matches the method signature, and the phase on the previous line is no longer an unused variable.

Details and comments

@garrison
Pass phase in PauliList.from_symplectic example
05f86b9 
I believe this is what was intended when the example was originally added
(Qiskit#5993), as this now matches the method signature, and the `phase`
on the previous line is no longer an unused variable.
@garrison garrison requested review from chriseclectic and a team as code owners December 22, 2021 22:22
jakelishman
jakelishman approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phase is an optional element, so it was already a valid function call (since it's in a jupyter-execute it would have errored the docs build if not), but I agree that it was meant to be passed in here.

@jakelishman jakelishman added automerge Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable labels Dec 23, 2021
@jakelishman jakelishman added this to the 0.19.2 milestone Dec 23, 2021
@mergify mergify bot merged commit 8e54baa into Qiskit:main Dec 23, 2021
mergify bot pushed a commit that referenced this pull request Dec 23, 2021
@garrison
Pass phase in PauliList.from_symplectic example (#7436)
20ef9d3 
I believe this is what was intended when the example was originally added
(#5993), as this now matches the method signature, and the `phase`
on the previous line is no longer an unused variable.

(cherry picked from commit 8e54baa)
@mergify mergify bot mentioned this pull request Dec 23, 2021
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1613274388

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.117%
Totals Coverage Status
Change from base Build 1608612829: 0.0%
Covered Lines: 51944
Relevant Lines: 62495
💛 - Coveralls

mergify bot added a commit that referenced this pull request Dec 23, 2021
@mergify @garrison
Pass phase in PauliList.from_symplectic example (#7436) (#7440)
98ae5cd 
I believe this is what was intended when the example was originally added
(#5993), as this now matches the method signature, and the `phase`
on the previous line is no longer an unused variable.

(cherry picked from commit 8e54baa)

Co-authored-by: Jim Garrison <[email protected]>
@garrison garrison mentioned this pull request Dec 23, 2021
Merged
@garrison garrison deleted the symplectic-phase-example branch December 24, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.
3 participants
@garrison @coveralls @jakelishman