Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated pass_manager arg to transpile() #7679

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Remove deprecated pass_manager arg to transpile() #7679

merged 4 commits into from
Feb 18, 2022

Conversation

towynlin
Copy link
Contributor

@towynlin towynlin commented Feb 17, 2022 •
edited
Loading

Summary

Removes the pass_manager kwarg to qiskit.compiler.transpile per @jakelishman's suggestion on issue #7663.

Details and comments

  • The change to transpiler.py is only deletions. I removed 2 unused functions: _check_conflicting_argument and _parse_pass_manager.
  • One test just needed the pass_manager kwarg removed.
  • Reno release note added that mostly copies the 0.13 deprecation note.

Please don't hesitate to let me know if there's more I can do.

@towynlin towynlin requested a review from a team as a code owner February 17, 2022 19:39
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mtreinish
mtreinish approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, it seems straightforward enough. Thanks for doing this

@mtreinish mtreinish added Changelog: Removal Include in the Removed section of the changelog automerge labels Feb 18, 2022
@mergify mergify bot merged commit 0fc885b into Qiskit:main Feb 18, 2022
@mtreinish mtreinish mentioned this pull request Feb 18, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1860868065

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.35%
Totals Coverage Status
Change from base Build 1860524077: 0.01%
Covered Lines: 52236
Relevant Lines: 62671
💛 - Coveralls

@towynlin towynlin deleted the remove-deprecated-pass-manager branch February 18, 2022 17:51
@jakelishman jakelishman mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@towynlin @CLAassistant @coveralls @mtreinish