-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily remove Operation class usage for 0.20 #7840
Conversation
Removing Operation release notes
Properties inherited from |
@@ -234,7 +234,6 @@ | |||
from .controlledgate import ControlledGate | |||
from .instruction import Instruction | |||
from .instructionset import InstructionSet | |||
from .operation import Operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to drop this here? This means we're not re-exporting the Operation class from the root qiskit.circuit
. This will limit who has access to the class. I'm fine with that as we're saying for 0.20.0 we added the class but nothing uses it yet. Just wanted to make sure that was the intent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Matthew, I think it's better this way before we re-add it in way that solves #7528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for doing this. Is there something we still need to do here to remove the WIP, I personally don't see anything missing from it.
Nothing else to do, I was waiting for the CI to finish (my lint + tests are still running locally, nice to see how fast those servers are :-) ). WIP removed |
Pull Request Test Coverage Report for Build 2064899040
💛 - Coveralls |
This PR temporarily removes
Operation
from being a base class for various circuit element types due to the performance degradation found in #7528 and given the fact that theOperation
class intent is still not utilized inQuantumCirctuit.append
Summary
Details and comments