Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efficient gate power methods #9318

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Conversation

kevinsung
Copy link
Contributor

Summary

Part of #9126 .

Details and comments

I deleted some references to gate labels in the tests. I think this is okay because some of generated labels are meaningless anyway, for example, unitary^3.

@kevinsung kevinsung requested a review from a team as a code owner December 21, 2022 17:10
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Dec 21, 2022

Pull Request Test Coverage Report for Build 3882068496

  • 62 of 62 (100.0%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.632%

Totals Coverage Status
Change from base Build 3881890210: 0.01%
Covered Lines: 64329
Relevant Lines: 76010

💛 - Coveralls

@kevinsung
Copy link
Contributor Author

CI failure appears unrelated

@kevinsung kevinsung added this to the 0.23.0 milestone Jan 6, 2023
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I left some comments below 🙂

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

@Cryoris Cryoris added Changelog: New Feature Include in the "Added" section of the changelog automerge labels Jan 10, 2023
@mergify mergify bot merged commit d3243e9 into Qiskit:main Jan 10, 2023
@kevinsung kevinsung deleted the efficient-gate-power branch January 10, 2023 11:53
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request Jan 11, 2023
* add efficient gate power methods

* fix imports

* override some more methods

* use scipy.linalg.fractional_matrix_power

* use assertIsInstance and add isinstance check

* lint

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants