Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of circuit depth filter function #9320

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

kevinsung
Copy link
Contributor

Summary

It was unclear whether the function should return True or False for instructions to ignore.

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner December 22, 2022 15:56
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Dec 22, 2022

Pull Request Test Coverage Report for Build 3875236970

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.583%

Totals Coverage Status
Change from base Build 3875236136: 0.0%
Covered Lines: 64086
Relevant Lines: 75767

💛 - Coveralls

@HuangJunye HuangJunye added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Dec 23, 2022
@kevinsung kevinsung added this to the 0.23.0 milestone Jan 6, 2023
@kdk kdk added the automerge label Jan 9, 2023
@mergify mergify bot merged commit 95b98d4 into Qiskit:main Jan 9, 2023
@kevinsung kevinsung deleted the doc-fix-circuit-depth branch January 9, 2023 18:13
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request Jan 11, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants