Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite needlessly confusing line #9551

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

kevinsung
Copy link
Contributor

Summary

I ran into this line during a PR review and found it needlessly confusing.

Details and comments

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed, it just took me an age to work out what was going on there as well.

@jakelishman jakelishman added Changelog: None Do not include in changelog automerge labels Feb 8, 2023
@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 4125840314

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 85.275%

Totals Coverage Status
Change from base Build 4118736041: 0.003%
Covered Lines: 67225
Relevant Lines: 78833

💛 - Coveralls

@mergify mergify bot merged commit d4006dd into Qiskit:main Feb 8, 2023
@kevinsung kevinsung deleted the fix-confusing-line branch February 8, 2023 19:00
pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants