-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing CouplingMap.__eq__ #9766
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1a7ea7b
implementing Coupling.__eq__
DanPuzzuoli 80a79ea
Update qiskit/transpiler/coupling.py
DanPuzzuoli c171a20
adding comments to test, and adding release note
DanPuzzuoli fe7165e
black formatting
DanPuzzuoli ffe2454
Merge branch 'main' into coupling_map_equality
DanPuzzuoli ed6b391
updating CouplingMap.__eq__ to check edge list equality instead of is…
DanPuzzuoli f7797ea
Merge branch 'coupling_map_equality' of github.com:DanPuzzuoli/qiskit…
DanPuzzuoli 4cc84ec
updating release notes
DanPuzzuoli f1c84ca
Merge branch 'main' into coupling_map_equality
DanPuzzuoli 507eb31
updating test doc string
DanPuzzuoli 66ad0ab
Merge branch 'coupling_map_equality' of github.com:DanPuzzuoli/qiskit…
DanPuzzuoli 8bbda72
Update test/python/transpiler/test_coupling.py
DanPuzzuoli d1f399e
Update test/python/transpiler/test_coupling.py
DanPuzzuoli 9c5886a
Update test/python/transpiler/test_coupling.py
DanPuzzuoli d89a826
Update test/python/transpiler/test_coupling.py
DanPuzzuoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
upgrade: | ||
- | | ||
The :meth:`.CouplingMap.__eq__`` method has been updated to check that the edge lists of the | ||
underlying graphs contain the same elements. Under the assumption that the underlying graphs are | ||
connected, this check additionally ensures that the graphs have the same number of nodes with | ||
the same labels. Any code using ``CouplingMap() == CouplingMap()`` to check object equality | ||
should be updated to ``CouplingMap() is CouplingMap()``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe having a comment here to say this will create a 5 node coupling map with 3 disconnected (it might not be obvious from a quick glance).