Skip to content

Commit

Permalink
Bump MSRV to 1.56.1 and update dependencies and Rust Edition (#717)
Browse files Browse the repository at this point in the history
The previous minimum support Rust version of 1.48 was originally
selected to match the latest version of Rust available through Debian
stable. This was done primarily to support the piwheels build
environemnt which installs rustc via Debian packages. However, the 1.48
MSRV is causing a lot development friction as it's quite old and is
holding back a lot of dependencies. When weighing the relatively tiny
piwheels user base (for an unsupported platform) against this it's
probably time to decouple our MSRV for rustworkx from that and pick a
version that makes the most sense for our development needs.

This commit raises the minimum supported rust version to 1.56.1 and then
bumps all our dependencies held back because of the previous MSRV. At
the same time the rust edition used for rustworkx is changed to be
edition 2021 instead of edition 2018. This will enable us to leverage
newer rust syntax now.

Fixes #716

Co-authored-by: Ivan Carvalho <[email protected]>
  • Loading branch information
mtreinish and IvanIsCoding authored Oct 28, 2022
1 parent cd1934d commit 70b7977
Show file tree
Hide file tree
Showing 11 changed files with 165 additions and 134 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
]
include:
# Test minimal supported Rust version
- rust: 1.48.0
- rust: 1.56.1
python-version: 3.8
platform: { os: "ubuntu-latest", python-architecture: "x64", rust-target: "x86_64-unknown-linux-gnu" }
msrv: "MSRV"
Expand Down
Loading

0 comments on commit 70b7977

Please sign in to comment.