Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call to deprecated np.alltrue with np.all #1054

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Replace call to deprecated np.alltrue with np.all #1054

merged 1 commit into from
Jan 16, 2024

Conversation

eendebakpt
Copy link
Contributor

The np.alltrue method will be removed in numpy 2.0.

mtreinish
mtreinish approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing this. I also checked and this function existed in our minimum supported numpy version of 1.16.0 so there shouldn't be any change needed there either.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jan 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7541117752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.923%
Totals Coverage Status
Change from base Build 7524114019: -0.04%
Covered Lines: 16024
Relevant Lines: 16705
💛 - Coveralls

@mergify mergify bot merged commit 6873679 into Qiskit:main Jan 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eendebakpt @coveralls @mtreinish