Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return the bridges of the graph #1058

Merged
merged 15 commits into from
Jan 20, 2024
Merged

Add function to return the bridges of the graph #1058

merged 15 commits into from
Jan 20, 2024

Conversation

inmzhang
Copy link
Contributor

Closes #1039

@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 7590295417

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 95.99%

Totals Coverage Status
Change from base Build 7589703011: 0.06%
Covered Lines: 16108
Relevant Lines: 16781

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So overall it looks great, my only concern is that articulation_point is a public function in rustworkx-core, so changing the signature is a breaking change.

I'd rather not break our existing rustworkx-core users, so I am suggesting keeping the old signature while calling an internal function that does the work to find the bridges

@inmzhang inmzhang requested a review from IvanIsCoding January 18, 2024 05:36
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanIsCoding IvanIsCoding merged commit 6931377 into Qiskit:main Jan 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: find bridges
3 participants