-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to return the bridges of the graph #1058
Conversation
Pull Request Test Coverage Report for Build 7590295417
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! So overall it looks great, my only concern is that articulation_point
is a public function in rustworkx-core
, so changing the signature is a breaking change.
I'd rather not break our existing rustworkx-core
users, so I am suggesting keeping the old signature while calling an internal function that does the work to find the bridges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the function to the documentation in https://github.com/Qiskit/rustworkx/blob/main/docs/source/api/algorithm_functions/connectivity_and_cycles.rst and we will be good to go
Closes #1039