Silence rust clippy lint enabled after the 1.84 release #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still some failures I need to investigate edit: well I guess PyO3 0.22 does leak some of their features in a public macro |
IvanIsCoding
commented
Jan 10, 2025
| @@ -71,6 +71,12 @@ version = "^0.11" | |||
| default-features = false | |||
| features = ["multi_thread"] | |||
|
|
|||
| [features] | |||
There was a problem hiding this comment.
This is ugly but it is the only way to make PyO3 0.22 work with Clippy. I will not bother opening a bug as the latest version already has a fix
There was a problem hiding this comment.
Yeah I think this is fine as a temporary fix I had to do the same thing on qiskit recently too: Qiskit/qiskit#13645
Pull Request Test Coverage Report for Build 12702725601Details
💛 - Coveralls |
mtreinish
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short the new clippy lint suggests us to replace
map_orwithis_none_or.But
is_none_oris only available for Rust 1.82 or newer (https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none_or). So we can revisit this but at the time it is best to ignore