-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in and out edge indices functions #1369
base: main
Are you sure you want to change the base?
Add in and out edge indices functions #1369
Conversation
Pull Request Test Coverage Report for Build 12926634311Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation looks good to me. I left some minor nitpick comments but they are not blocking.
What is going to be more work is adding even more methods...
PyGraph
should have the same methods even if the implementation is just callingincident_edges
for consistencyPyDiGraph
andPyGraph
could use aout_edge_indices
So that is 3 more methods which were in the original request but are useful to maintain some coherence accross the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I will run this through @mtreinish before adding four similar methods for a second opinion
This PR introduces a new method, in_edge_indices, to the rustworkx.PyDiGraph class. The method returns the indices of incoming edges for a specified node.
#1360
I'll add the documentation once the function signature is finalized.