Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random_geometric_graph #295

Merged
merged 8 commits into from
May 4, 2021
Merged

Add random_geometric_graph #295

merged 8 commits into from
May 4, 2021

Conversation

georgios-ts
Copy link
Collaborator

Closes #286
Adds a new random_geometric_graph function to generate random geometric graphs.

@coveralls
Copy link

coveralls commented Mar 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 809802383

  • 66 of 67 (98.51%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 96.575%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 66 67 98.51%
Totals Coverage Status
Change from base Build 809800808: 0.05%
Covered Lines: 6909
Relevant Lines: 7154
💛 - Coveralls

nahumsa
nahumsa reviewed Mar 27, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@mtreinish mtreinish added this to the 0.9.0 milestone Apr 23, 2021
mtreinish
mtreinish reviewed May 3, 2021
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment inline about argument typing, I've typically been handling the python defaults via the pyfunction macro, it makes the code a bit cleaner.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
mtreinish
mtreinish approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick update.

@mtreinish mtreinish merged commit 9f6b705 into Qiskit:main May 4, 2021
@georgios-ts georgios-ts deleted the pr-rand-geom branch May 8, 2021 07:40
@georgios-ts georgios-ts mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahumsa nahumsa nahumsa left review comments

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Add random_geometric_graph function
4 participants
@georgios-ts @coveralls @mtreinish @nahumsa