-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heavy square code to generators #313
Merged
+873
−0
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
127f685
Merge pull request #2 from Qiskit/master
nahumsa b452ce4
Merge pull request #3 from Qiskit/main
nahumsa 677bbdd
add heavy square graph to generators
nahumsa 9f3e465
add release notes
nahumsa 81f0557
Merge branch 'main' into heavy-square-code
nahumsa 257748c
add heavy square edge assertion
nahumsa 063aee6
Merge remote-tracking branch 'upstream/main' into heavy-square-code
nahumsa d23bed1
Merge branch 'main' into heavy-square-code
nahumsa 6320adc
Merge remote-tracking branch 'upstream/main' into heavy-square-code
nahumsa bee8ec8
add reference on the docs
nahumsa a309aa0
fmt
nahumsa c06c72a
updated text_signature
nahumsa c2fc6f5
fmt
nahumsa 43044d6
fix doc identation
nahumsa d83835b
Add code block for ASCII
nahumsa 316005e
lint
nahumsa 60a150b
add note about the four-frequency variant
nahumsa 3b2e17e
Merge branch 'main' into heavy-square-code
nahumsa fc46699
add `directed_heavy_square_code`
nahumsa d18c547
Merge branch 'main' into heavy-square-code
nahumsa fe32a81
Fix edge directions
mtreinish 640efb2
Merge remote-tracking branch 'origin/main' into heavy-square-code
mtreinish b63af4c
Update edge directions in tests
mtreinish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add reference on the docs
commit bee8ec86c73a46abbca9db712e26df330dd52871
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a variant of the heavy square lattice (see Fig 10.b, right-hand side) whose edge case handling (lines 1054-1075 in the present PR) is a bit different. No comment on whether it's worth including as an option, but it is definitely worth mentioning in the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any suggestion how this can be mentioned in the docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only important thing is to bring to the reader's attention that there is another variant and to disambiguate which you mean. So, something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note was added on
60a150b
.