Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retworkx compat artifact CI job #692

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

mtreinish
Copy link
Member

Before pushing the 0.12.0 tag I noticed the CI configuration for the retworkx release artifacts was broken and wouldn't run because of a dependency on the rustworkx jobs that was defined in a separate workflow. This commit updates the CI config by adding the retworkx artifact job to the wheels workflow so we can express the dependency on rustworkx being published first.

Before pushing the 0.12.0 tag I noticed the CI configuration for the
retworkx release artifacts was broken and wouldn't run because of a
dependency on the rustworkx jobs that was defined in a separate
workflow. This commit updates the CI config by adding the retworkx
artifact job to the wheels workflow so we can express the dependency on
rustworkx being published first.
@mtreinish
Copy link
Member Author

After this merges I'll tag and push 0.12.0 to trigger the release. Glad I caught this so I didn't have to do the retworkx artifacts manually (I was about to push the tag and was double checking before I did).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3200481236

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.036%

Totals Coverage Status
Change from base Build 3200422820: 0.0%
Covered Lines: 13260
Relevant Lines: 13665

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, rustworkx should be in PyPI before retworkx such that we can depend on it.

@IvanIsCoding IvanIsCoding merged commit f3beb8b into Qiskit:main Oct 6, 2022
@mtreinish mtreinish deleted the fix-ci-job-config branch November 8, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants