Add extra methods to PyDAG class #9
Merged
+177
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 3 new methods to the PyDAG class to add equivalent functionality to some networkx methods. The first two are in_edges and out_edges. These functions are basically the same as adj_direction except it's split by direction and also changes the output format to be a list of tuples with node indexes and edge data. This way one can reproduce/recreate the edges in the graph easily. The third method is out_degree, which is the missing dual of in_degree but for the other direction.
This commit adds 2 more method implementations to the PyDAG class. First it adds support for calling len() on PyDAG objects which will return the number of nodes in the graph. The second is a new method get_node_data() which will return the object stored for a node at a given index.
This commit updates the documentation to reflect the current state of the repo. First it adds a definition for __len__() which was missing from the previous commit. Additionally, it fixes the class preamble to not mention daggy anymore since that's not used. It also removes the bit about indexes changing on removal since the use of StableGraph internally has removed that limitation. It now only mentions that nodes and edges are indexed with integers instead of using the data/weight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds 3 new methods to the PyDAG class to add equivalent
functionality to some networkx methods. The first two are in_edges and
out_edges. These functions are basically the same as adj_direction
except it's split by direction and also changes the output format to
be a list of tuples with node indexes and edge data. This way one can
reproduce/recreate the edges in the graph easily. The third method is
out_degree, which is the missing dual of in_degree but for the other
direction.