This repository has been archived by the owner on Jan 12, 2025. It is now read-only.
Docker compatibility #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows could not build because of CRLF/LF files configuration. So Dockerfile converts files to LF.
We don't need .bat file as Dockerfile uses alpine (linux)
For those who uses vscode
Docker will keep in cache the build until source is updated
Also do some refactor
Also refactor some code in Dockerfile
|
Re-post of what I posted in Quackster/Havana#50, as the same applies here: Some feedback:
https://cloud.google.com/java/getting-started/jib https://github.com/emansom/Kepler/blob/master/Kepler-Server/build.gradle#L18 |
AlexandreVassard
added a commit
to AlexandreVassard/Kepler
that referenced
this pull request
Aug 27, 2024
Merge pull request Quackster#72 from AlexandreVassard/master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I wanted to make Kepler compatible with Docker.
So i made a Dockerfile (based on alpine to have the smallest image possible).
The entrypoint will, at first init, run Kepler to get the default server.ini
After that, it will take all values from .env and put them in server.ini
WARN : mysql.username is MYSQL_USER because it's also used in MariaDB.
The Dockerfile does the same thing that is done in Github actions (CI) for a release.
If you have any questions or need help to deploy Docker image with CI, please ask.