Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update as per peer review #8

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

ashutoshrana171
Copy link
Contributor

@ashutoshrana171 ashutoshrana171 commented Feb 7, 2024

Update process.ipynb

Description

Updated process.ipynb file by adding try, catch sleep, and retry in cell 5

Motivation and Context

We updated process.ipynb to handle exceptions.

Requires Documentation Change

No

How Has This Been Tested?

  1. Tested the script to handle connectivity issues by breaking the internet connection during the process and providing it back during a different interval of time. The script handled the exceptions as expected. When connection is lost until the script passes all retries it throws an exception at the end as expected after 5 retries.

  2. Passed a faulty JSON to process within the script to handle JSONDecodeErrror or JSON-related exceptions that were not caught in the master script. The master script would throw a JSONDecodeError exception.
    Adding try, catch, sleep, and retry blocks handles this exception correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@ashutoshrana171 ashutoshrana171 changed the title Update process.iypnb Update process as per peer review Feb 8, 2024
@ashutoshrana171 ashutoshrana171 changed the title Update process as per peer review Update as per peer review Feb 8, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@Martin-Molinero Martin-Molinero merged commit d42d705 into QuantConnect:master Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants