Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getFileType function #35

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Update getFileType function #35

merged 6 commits into from
Jan 22, 2025

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Jan 20, 2025

Update getFileType function to consider directories which include . in their names (a false extension), when returning the object type, mimetype and format.

This PR builds on #34 and refactors the functionalities to integrate the directory check and remove redundancy.

@DenisaCG DenisaCG self-assigned this Jan 20, 2025
@DenisaCG DenisaCG added the enhancement New feature or request label Jan 20, 2025
@DenisaCG DenisaCG requested a review from afshin January 21, 2025 12:43
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Question for a future PR, can incrementName be made protected instead of public? Or do you need to use it externally as well?

@DenisaCG
Copy link
Member Author

Thanks for the review!

can incrementName be made protected instead of public? Or do you need to use it externally as well?

Good point. I checked and it can be made protected, I will open a follow up PR addressing this. Thanks!

@DenisaCG DenisaCG merged commit 205ab5e into main Jan 22, 2025
6 checks passed
@DenisaCG DenisaCG deleted the fileType branch January 22, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants