-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prepare script and revert PR #20 #24
Conversation
package.json
Outdated
@@ -83,6 +83,9 @@ | |||
"before-build-npm": [ | |||
"python -m pip install jupyterlab~=3.0", | |||
"jlpm" | |||
], | |||
"before-build-python": [ | |||
"jlpm clean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check if this forces a prod build.
Thanks @jtpio!!! |
Yes, it is probably coming from there. Do you know if there is a reason to use the editable mode there? |
Would have to investigate further to confirm, but a first guess could be so that it picks up later changes such as the version bump of the Python package. |
Opened jupyterlab/extension-cookiecutter-ts#199 as follow-up. |
Remove prepare script and revert PR #20