Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prepare script and revert PR #20 #24

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

hbcarlos
Copy link
Contributor

Remove prepare script and revert PR #20

@hbcarlos hbcarlos added bug Something isn't working maintenance labels Jan 24, 2022
@hbcarlos hbcarlos self-assigned this Jan 24, 2022
@hbcarlos hbcarlos requested a review from jtpio January 24, 2022 15:57
@hbcarlos hbcarlos marked this pull request as draft January 24, 2022 16:22
package.json Outdated
@@ -83,6 +83,9 @@
"before-build-npm": [
"python -m pip install jupyterlab~=3.0",
"jlpm"
],
"before-build-python": [
"jlpm clean"
Copy link
Member

@jtpio jtpio Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if this forces a prod build.

@jtpio
Copy link
Member

jtpio commented Jan 24, 2022

Looking better after forcing the clean:all before the build-python step:

image

We should also double check if it builds in dev mode because of the first python -m pip install . in prep-git:

image

@hbcarlos
Copy link
Contributor Author

Thanks @jtpio!!!

@hbcarlos hbcarlos marked this pull request as ready for review January 24, 2022 21:42
@hbcarlos
Copy link
Contributor Author

We should also double check if it builds in dev mode because of the first python -m pip install . in prep-git:

Yes, it is probably coming from there. Do you know if there is a reason to use the editable mode there?
https://github.com/jupyter-server/jupyter_releaser/blob/ca540f3441045db34d1b433c8a0714a9f97648ba/jupyter_releaser/lib.py#L565-L568

@jtpio
Copy link
Member

jtpio commented Jan 25, 2022

Do you know if there is a reason to use the editable mode there?

Would have to investigate further to confirm, but a first guess could be so that it picks up later changes such as the version bump of the Python package.

@hbcarlos hbcarlos merged commit 854af20 into jupyterlab-contrib:main Jan 25, 2022
@hbcarlos hbcarlos deleted the build-prod branch January 25, 2022 09:02
@jtpio
Copy link
Member

jtpio commented Jan 25, 2022

Would have to investigate further to confirm, but a first guess could be so that it picks up later changes such as the version bump of the Python package.

Opened jupyterlab/extension-cookiecutter-ts#199 as follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants