Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build js in prod mode for the release #20

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Build js in prod mode for the release #20

merged 1 commit into from
Jan 21, 2022
+1 −2

Conversation

hbcarlos
Copy link
Contributor

@hbcarlos hbcarlos commented Jan 16, 2022 •
edited
Loading

Follows #19

@hbcarlos hbcarlos marked this pull request as draft January 16, 2022 13:17
@hbcarlos
Copy link
Contributor Author

Check release fails related to jupyter-server/jupyter_releaser#131

@hbcarlos hbcarlos closed this Jan 19, 2022
@hbcarlos hbcarlos reopened this Jan 19, 2022
@hbcarlos hbcarlos changed the title [WIP] Tests releaser Build js in prod mode for the release Jan 21, 2022
@hbcarlos hbcarlos requested a review from jtpio January 21, 2022 09:48
@hbcarlos hbcarlos marked this pull request as ready for review January 21, 2022 09:48
jtpio
jtpio approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that should do it, thanks!

@hbcarlos
Copy link
Contributor Author

Thank you soo much @jtpio!
Merging and making a release to check that everything it's okay!

@hbcarlos hbcarlos merged commit 2b89331 into jupyterlab-contrib:main Jan 21, 2022
@hbcarlos hbcarlos deleted the dev branch January 21, 2022 11:17
hbcarlos added a commit to hbcarlos/jupyterlab-js-logs that referenced this pull request Jan 24, 2022
@hbcarlos
Remove prepare script and revert PR jupyterlab-contrib#20
bbd2593
@hbcarlos hbcarlos mentioned this pull request Jan 24, 2022
Merged
hbcarlos added a commit that referenced this pull request Jan 25, 2022
@hbcarlos
Merge pull request #24 from hbcarlos/build-prod
854af20 
Remove prepare script and revert PR #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hbcarlos @jtpio