Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Account for argparse bug fix in Python 3.13 #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DemiMarie
Copy link
Contributor

Test test_004_enable_opt_mixed is marked as xfail because of an argparse bug, but the bug is fixed in Python 3.13 so the test unexpectedly succeeds. Remove the @unittest.expectedFailure, skip it on Python<3.13, and add a new tests for older Python that checks for the previous buggy behavior.

@marmarek
Copy link
Member

marmarek commented Jan 8, 2025

CI says "syntax error"

Test test_004_enable_opt_mixed is marked as xfail because of an argparse
bug, but the bug is fixed in Python 3.13 so the test unexpectedly
succeeds.  Remove the @unittest.expectedFailure, skip it on Python<3.13,
and add a new tests for older Python that checks for the previous buggy
behavior.
@DemiMarie
Copy link
Contributor Author

I did test these changes locally, but I also used black to try to format the new code properly, and that required running git add -p or similar. I suspect that while the code I had checked out was fine, the code I committed and pushed was broken. Should be fixed now.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.24%. Comparing base (3b9da29) to head (6461531).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files          52       52           
  Lines        8975     8975           
=======================================
  Hits         6753     6753           
  Misses       2222     2222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants