Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message on testflight upload or validation #240

Conversation

VincentDucastel
Copy link

Hello,

Recently, when i upload my archive on testflight, i have the following warning :

Capture d’écran 2022-09-29 à 15 31 23

After searching, i found the code that generate this warning.
Class : GestureRecognizerTarget.swift
Method : handle(_ gestureRecognizer: UIGestureRecognizer)

The method signature "handle(_ gestureRecognizer: UIGestureRecognizer)" is in conflict with validation Apple, use another name : "handleMyGesture" for example

@VincentDucastel
Copy link
Author

Hello,

No news?

@pauljohanneskraft
Copy link
Collaborator

Are you sure that this is an issue with this library in particular? As far as I know, we did not have any such issues so far and I have also not heard from other developers that this piece of code produces a warning. Have you checked whether this adaption actually resolves the issue for you?

I will have a deeper look until next week in this, and we might rename it to handleGesture(of:).

@VincentDucastel
Copy link
Author

Hello Paul,

Yes, I am sure.
First, i searched in all of my code. No result.
After, i searched in different libraries. By elimination.

Result : I have no the warning if i remove the library XCoordinator.
I searched in the library XCoordinator with keyword "handle" to find the class : GestureRecognizerTarget.swift
I tested to modify the method :

@objc
    private func handle(_ gestureRecognizer: UIGestureRecognizer) {
        guard let recognizer = gestureRecognizer as? GestureRecognizer else { return }
        handler(recognizer)
    }

I have no warning with your proposition : handleGesture(of:)

@objc
    private func handleGesture(of gestureRecognizer: UIGestureRecognizer) {
        guard let recognizer = gestureRecognizer as? GestureRecognizer else { return }
        handler(recognizer)
    }

@VincentDucastel
Copy link
Author

@pauljohanneskraft

@pauljohanneskraft
Copy link
Collaborator

Okay, thank you for testing! @VincentDucastel

I will try to release it in the coming week alongside #239

@VincentDucastel
Copy link
Author

Thanks !

@pauljohanneskraft
Copy link
Collaborator

Thank you for your contribution!

@pauljohanneskraft pauljohanneskraft merged commit 25bfa59 into QuickBirdEng:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants