Antmicro Code review changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ephyr into code_review_changes1
-Added new config EOS_S3_PWM which loads litex pwm ip bit stream and then uses litex pwm driver -Renamed EOS_S3_LED1 as EOS_S3_LED_BASIC; in configuration files, driver files and sample files -Cleanup in fpga_loader.c file. Instead of using hardcoded register addresses using HAL defined macros -Moved the common code used in soc.c and fpga_loader.c to a common function enable_fpga_clocks() -Resolved coding style related issues in all .c files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added new config EOS_S3_PWM which loads litex pwm ip bit stream and then uses litex pwm driver.
-Renamed EOS_S3_LED1 as EOS_S3_LED_BASIC; in configuration files, driver files and sample files
-Cleanup in fpga_loader.c file. Instead of using hardcoded register addresses using HAL defined macros
-Moved the common code used in soc.c and fpga_loader.c to a common function enable_fpga_clocks()
-Resolved coding style related issues in all .c files