Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The highlights grid doesn't appear over the scrollbar but on the left side of the window #293

Open
mzso opened this issue Mar 15, 2017 · 5 comments

Comments

@mzso
Copy link

mzso commented Mar 15, 2017

Hi!

This is fairly recent issue on moz-central. So now that development halted is there anyone out there who knows what's going on?
It might be a simple fix since the feature itself is not broken, but appears to not find the scrollbar.

@pintassilgo
Copy link

pintassilgo commented Mar 25, 2017

Mozilla changed the LocaleService API, so outdated FindBar Tweak code can't detect the user language, reverting to (code) default RTL (right-to-left), that is, thinking that scrollbar is in the left side.

https://hg.mozilla.org/mozilla-central/diff/20075fb33fc7/toolkit/modules/Services.jsm

https://bugzilla.mozilla.org/show_bug.cgi?id=1337551

To fix this, change line 763 of resource/modules/content/grid.jsm
from
var appLocale = Services.locale.getApplicationLocale().getCategory("NSILOCALE_MESSAGES");
to
var appLocale = Services.locale.getAppLocale();

Or simply set about:config
layout.scrollbar.side = 2

@mzso
Copy link
Author

mzso commented Mar 25, 2017

@pintassilgo commented on Mar 25, 2017, 9:23 AM GMT+1:

Mozilla changed the LocaleService API, so outdated FindBar Tweak code can't detect the user language, reverting to (code) default RTL (right-to-left), that is, thinking that scrollbar is in the left side.

https://hg.mozilla.org/mozilla-central/diff/20075fb33fc7/toolkit/modules/Services.jsm

https://bugzilla.mozilla.org/show_bug.cgi?id=1337551

To fix this, change line 763 of resource/modules/content/grid.jsm

from

var appLocale = Services.locale.getApplicationLocale().getCategory("NSILOCALE_MESSAGES");

to

var appLocale = Services.locale.getAppLocale();

Or simply set about:config

layout.scrollbar.side = 2

Thanks!
Sadly, this change in the code doesn't seem to help. The highlights still appear on the left.

@mzso
Copy link
Author

mzso commented Apr 18, 2017

So, since this change doesn't work can I expect negative effects in some circumstances from setting using "layout.scrollbar.side = 2"?

@harl
Copy link

harl commented Apr 24, 2017

http://kb.mozillazine.org/Layout.scrollbar.side

Basically, if LTR is the only content direction you care about, then it's rather unlikely you will see any negative effects from changing that variable. - On the other hand, if it behaves differently from your expectations on RTL pages (or whatever), then it's pretty easy to change it back to 0 or 1 (or 3 if 0 or 1 don't work).

You can set it to 1 and see if that solves this issue without interfering with any content, as it should have the same effect as setting it to 2 on LTR content but still let the scrollbar change accordingly when needed.

Bottom line, set it to 1 and it might just work out for you, or set it to 2 to force it to the right side.

@mzso
Copy link
Author

mzso commented Apr 25, 2017

@harl commented on Apr 24, 2017, 1:54 PM GMT+2:

http://kb.mozillazine.org/Layout.scrollbar.side

Basically, if LTR is the only content direction you care about, then it's rather unlikely you will see any negative effects from changing that variable. - On the other hand, if it behaves differently from your expectations on RTL pages (or whatever), then it's pretty easy to change it back to 0 or 1 (or 3 if 0 or 1 don't work).

You can set it to 1 and see if that solves this issue without interfering with any content, as it should have the same effect as setting it to 2 on LTR content but still let the scrollbar change accordingly when needed.

Bottom line, set it to 1 and it might just work out for you, or set it to 2 to force it to the right side.

Thanks. layout.scrollbar.side;1 seems to work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants