Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync 1.19.2 to 0.76.0 #90

Merged
merged 15 commits into from
Mar 26, 2023
Merged

sync 1.19.2 to 0.76.0 #90

merged 15 commits into from
Mar 26, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Mar 26, 2023

was a simple merge, all tests pass! (well, except the recipe remainder one that's been broken for a while)

PepperCode1 and others added 15 commits February 23, 2023 10:22
* Apply disabled shade from vanilla quads directly to material

- Remove QuadViewImpl.shade

* Fix enhanced AO calculation and respect non-terrain culling state

- Fix AoCalculator using AO face data computed with a potentially different shade state
- Move non-cached computation code to separate method in AoCalculator
- Turn AoCalculator's brightnessFunc and aoFunc into abstract methods
- Do not check null check world in non-terrain AO calculation since it cannot be null
- Pass through lightFace and shade state as method arguments in AoCalculator methods to prevent additional lookups
- Do not check for the axis aligned flag in AbstractQuadRenderer.shadeFlatQuad
- Respect cull parameter passed to non-terrain rendering by merging TerrainBlockRenderInfo into BlockRenderInfo
- Use reusable search pos when calling Block.shouldDrawSide to prevent additional BlockPos allocation
- Change BlockRenderContext.render and TerrainRenderContext.tessellateBlock to return void since return value is no longer used
- Remove QuadViewImpl.vertexStart since it is unused

* Add suggestions

- Mark Direction parameter to BlockRenderInfo.shouldDrawFace as Nullable
- Reuse MaterialFinder in FrameBakedModel

(cherry picked from commit 3a95925)
(cherry picked from commit 09aba06)
* add windswept biome tag

* change windswept tag to windswept hills

* list out biomes and revert name change

(cherry picked from commit 1b66477)
(cherry picked from commit 348a9c6)

(cherry picked from commit f1c68e5)
* Birch Forest Tag FabricMC#2330

* Fix FabricMC#2649

* Run datagen

(cherry picked from commit 315602f)
(cherry picked from commit 521b5c5)
(cherry picked from commit 36d2fcc)
(cherry picked from commit 8368a8b)
* Update ko_kr.json

* fix typo

(cherry picked from commit 930b8d4)
(cherry picked from commit eeb6cf3)
(cherry picked from commit 9af20fd)
(cherry picked from commit 93582b9)
# Conflicts:
#	fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/mixin/biome/TheEndBiomeSourceMixin.java
#	fabric-resource-loader-v0/src/main/java/net/fabricmc/fabric/impl/resource/loader/ModResourcePackUtil.java
#	fabric-resource-loader-v0/src/main/resources/assets/quilted_fabric_resource_loader_v0/lang/zh_cn.json
#	gradle.properties
Copy link

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when older versions end losing features from newer on- looks at 1.18.2 oh no;
Anyway, the only nitpick that I have is about license headers, but yeah, i feel like i might be able to do a fixing pass with a fixed licenser later

@ix0rai
Copy link
Member Author

ix0rai commented Mar 26, 2023

not sure fixing licenses for older versions is worth it :p

@EnnuiL EnnuiL merged commit b92eded into QuiltMC:1.19.2 Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.