-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick and probably nasty kludge to introduce increased entropy method… #3
Conversation
… for the sessionStoreKey
this has not been functionally tested at this moment in time please lmk if there is some areas I have missed, thanks! |
improvement for #2 to raise entropy shannon scale to ~6.02 for |
Yeah I've a lot to cleanup here, bare with me 😓 |
…ewrite similar logic, now to make it work with the rest of the codebase 😓
…ewrite similar logic, now to make it work with the rest of the codebase 😓
alright @pdavies011010 please t.a.l, I suspect this is probably horrible, however this should be tested and if functional can be merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Oneiroi , if you just want to remove those two functions we'll get this merged in and tested
util/util.go
Outdated
} | ||
return base64.RawURLEncoding.EncodeToString(challenge) | ||
} | ||
|
||
// Generate a random string of alpha characters of length n | ||
func RandStringBytesRmndr(n int) []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Oneiroi Yep looks like you can remove RandInit and RandStringBytesRmndr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed within #f7f4776
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over to you @pdavies011010 🙇
… for the sessionStoreKey