Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAI key error. Add docstrings. Polish code #24

Merged

Conversation

dSupertramp
Copy link
Contributor

Hi everyone!
This tool is amazing! I really want to be part of it!

Here's some changes:

  • Add python-dotenv, to make sure that the OpenAI API key works
  • Add some docstrings and some typing
  • Add python-dotenv into Pipfile

I'm willing to work into the extraction part!

@chloedia chloedia self-assigned this Jun 5, 2024
@chloedia
Copy link
Collaborator

chloedia commented Jun 5, 2024

Hey @dSupertramp thanks for contributing ! Don't hesitate to suggest ideas on the extraction part.

On my end I think it would be interesting to try upgrading the table integration and adding other medias like images for pdf ! With a notion of :
-> is the image really relevant to be added in the md
-> add image description in img metadata

Using multimodal !
What do you think ?

There is also a lot to add on the docx/pptx part to have the cleanest md possible!

@chloedia chloedia merged commit 94dd1ba into QuivrHQ:main Jun 5, 2024
@dSupertramp dSupertramp deleted the feat/add-docstrings-and-fix-openai-key branch June 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants