Reduce the number of calling vital#of() #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove calling vital#of() in bufManager.vim because the result is unused - Remove calling vital#of() in ftplugin/typescript.vim because tsuquyomi#config#preconfig() already checks ProcessManager.is_available().
Quramy
added a commit
that referenced
this pull request
Jul 21, 2015
Reduce the number of calling vital#of()
|
@rhysd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vital#of()呼び出しは使われていないようでしたので削除しましたvital#of()はProcessManager.is_available()のために呼ばれていますが，ProcessManager.is_available()はすでにtsuquyomi#config#preconfig()内でチェック済みのため不要のようです．よって削除しました．なお，
vital#of()は結構重い処理で複数回呼ぶと環境によっては問題になったりするため，多くのプラグインでは一度vital#of()を呼んだ時の結果を持っておいて使い回しているようです． （例えば neocomplete）よろしければご検討ください．