Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise page creates link to offset that is beyond end of recording. #196

Closed
cofiem opened this issue Mar 22, 2015 · 1 comment
Closed

Comments

@cofiem
Copy link
Contributor

cofiem commented Mar 22, 2015

e.g. http://baw.ecosounds.org/visualize?siteId=1028 links to http://baw.ecosounds.org/listen/241945?start=7200

{
  "meta":
    {
    "status":422,
    "message":"Unprocessable Entity",
    "error":{
       "details":"The request could not be understood: start_offset parameter (7200.0) must be smaller than the duration of the audio recording (7199.0044)."
    }
  },
  "data":null
}
@cofiem
Copy link
Contributor Author

cofiem commented Mar 22, 2015

atruskie added a commit that referenced this issue Jul 20, 2015
Now tracks image success and failure. It uses this info to generate cleaner
svg tiles (with out the palceholder rect and text). Cleaning is done when an image
is loaded, and after that, if the tile is loaded again, the extra svg is never generated.
These changes unfortunately do not work with internet explorer (see #215).

Also fixed firefox incompatibility (Fixes #198).
Also fixed the rendering of extra tiles (Fixes #201 and Fixes #196).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant